Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for access revoking #47

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ishmelev-sp
Copy link
Contributor

An update to support features from the new release of uplink-c, according to messages from this PR.

Notes:

  1. It works on macOS, but I couldn't test it on Windows, because I have no one. Could anybody do it? It needs only to run npm install, configure a path to .dll (like it's described in README.md), and run npm test.
  2. Here I propose a new way to handle the results of promises with chai-as-promised library. It's more convenient than waiting for the result and checking it.

@kmozurkewich
Copy link
Member

Thanks @ishmelev-sp - we'll review this week.

@kmozurkewich
Copy link
Member

kmozurkewich commented Feb 16, 2022

@ishmelev-sp - just an update: this looks like it will be in the queue for late next week for review. Thank you very much for the submission!

@ishmelev-sp
Copy link
Contributor Author

Guys, do we have any updates?

@kmozurkewich
Copy link
Member

kmozurkewich commented Feb 28, 2022

Hi @ishmelev-sp - no updates as of now. This is in the queue, however, code review updates are a lower priority task in sprints right now.

@alex-utropicmedia
Copy link

Hi, @ishmelev-sp, I got some issue while running test with "yarn test"
image
The only failed is with "Revoke access"
I attached screeshot, and please give me feedback

@ishmelev-sp
Copy link
Contributor Author

It's strange, thank you. I had tested it before, all tests passed. Hmmm... maybe I missed something....
I will check it in the nearest time.

@alex-utropicmedia
Copy link

thanks, just let me know if any updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants